Re: Oops in get_boot_pages at reboot

From: Andrew Morton
Date: Thu Apr 01 2004 - 13:59:07 EST


Olof Johansson <olof@xxxxxxxxxxxxxx> wrote:
>
> So __pollwait() calls __get_free_page(), system_running is 0 so
> get_boot_pages is called. Since get_boot_pages is labeled __init, badness
> happens.
>
> How about checking against mem_init_done instead of system_running? It
> helps against the oops, but there might be some good reason not to do
> it. I don't claim to know the intrisic details about the MM. :-)

Do we really need to clear system_running at reboot? I'd always viewed it
as "everything is initialised and usable", and that's generally true at
reboot time.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/