Re: via82xx cmd line parsing is evil [was Re: Sound on newer arima notebook...]

[Takashi Iwai]

At Thu, 1 Apr 2004 11:04:52 +0200,
Pavel Machek wrote:
> 
> Hi!
> 
> 
> > > snd-via82xx=enable:1 syntax is ugly, too, and we have better syntax
> > > already. via82xx.enable=1 via82xx.ac97_quirk=2 should be possible with
> > > new param handling code.
> > 
> > oh that's good to know.
> 
> And here's a patch. It compiles.

heh, we're crossfiring :)

> @@ -82,33 +81,36 @@
>  static int joystick[SNDRV_CARDS];
>  #endif
>  static int ac97_clock[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = 48000};
> -static int ac97_quirk[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = AC97_TUNE_DEFAULT};
> -static int dxs_support[SNDRV_CARDS];
> +static int ac97_quirk[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = 1};
> +static int dxs_support[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = 1};

i suppose that ac97_quirk=1 and dxs_support=1 work fine with your
machine?
(i don't want to change defaults for all devices yet :)


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/