Re: [patch 1/22] Add __early_param for all arches

[Rusty Russell]

On Thu, 2004-04-01 at 02:13, Tom Rini wrote:
> My first concern is can parse_args & co really be run so very early on ?

If you can run normal C code, yes.  It doesn't require any
initialization.

> Also:

> > +/* Arch code calls this early on. */
> > +void __init parse_early_options(const char *saved_command_line)
> > +{
> > +	static char __initdata command_line[COMMAND_LINE_SIZE];
> > +	strcpy(command_line, saved_command_line);
> 
> Really should be:
> /* i386 goes right to saved_command_line */
> if (*cmdline_p != saved_command_line)
> 	memcpy(saved_command_line, *cmdline_p, COMMAND_LINE_SIZE);
> /* ensure NUL terminated. */
> saved_command_line[COMMAND_LINE_SIZE - 1] = '\0';

Why?  Other than the nul term (which I agree with), I didn't understand
that code.  

Get the archs to pass some command line in.  eg. i386 can do:

-	parse_cmdline_early(cmdline_p);
+	parse_early_options(*cmdline_p);

I feel that anyone destroying command lines should do their own
saving, and we should head that way...

Thanks,
Rusty.
-- 
Anyone who quotes me in their signature is an idiot -- Rusty Russell

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/