Re: [PATCH] add PCI_DMA_{64,32}BIT constants

[Jeff Garzik]

Randy.Dunlap wrote:
> On Tue, 23 Mar 2004 00:23:05 -0500 Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
>
> | 
> | Been meaning to do this for ages...
> | 
> | Another one for the janitors.
>
>
> > > > Nice, I've pulled this to my pci tree and will forward it on to Linus in
> > > > the next round of pci patches after 2.6.5 is out.
> > >
> > > Yeah well...  in the intervening time, somebody on IRC commented
> > >
> > > "so what is so PCI-specific about those constants?"
> > >
> > > They probably ought to be DMA_{32,64}BIT_MASK or somesuch.
> >
> >
> > Heh, ok, care to make up another patch for this?  :)
>
>
>
> Here's an updated patch, applies to 2.6.5-rc2-bk9.
> I left the DMA_xxBIT_MASK defines in linux/pci.h, although
> they aren't necessarily PCI-specific.  Would we prefer to
> have them in linux/dma-mapping.h ?


Put them whereever the DMA direction constants are, I suppose...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/