Re: [PATCH] ppc32: Fix sector_t definition with CONFIG_LBD

From: Andi Kleen
Date: Mon Mar 29 2004 - 03:17:05 EST


Andrew Morton <akpm@xxxxxxxx> writes:

> Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > sector_t depends on CONFIG_LBD but include/config.h may not be there
> > thus causing interesting breakage in some places...
>
> Nasty.
>
> > Here's the fix for ppc32 (problem found by Roman Zippel, other archs
> > need a similar fix).
>
> Three of them.
>
> 25-akpm/include/asm-s390/types.h | 2 ++
> 25-akpm/include/asm-sh/types.h | 2 ++
> 25-akpm/include/asm-x86_64/types.h | 2 ++

Please use this change for x86-64 instead.

-Andi

diff -u linux-2.6.5rc2-amd64/include/asm-x86_64/types.h-o linux-2.6.5rc2-amd64/include/asm-x86_64/types.h
--- linux-2.6.5rc2-amd64/include/asm-x86_64/types.h-o 2004-03-21 21:11:54.000000000 +0100
+++ linux-2.6.5rc2-amd64/include/asm-x86_64/types.h 2004-03-29 04:44:24.000000000 +0200
@@ -48,10 +48,8 @@
typedef u64 dma64_addr_t;
typedef u64 dma_addr_t;

-#ifdef CONFIG_LBD
typedef u64 sector_t;
#define HAVE_SECTOR_T
-#endif

#endif /* __ASSEMBLY__ */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/