Re: [PATCH 15/22] /dev/random: kill unrolled SHA code

[Matt Mackall]

On Thu, Mar 25, 2004 at 08:43:13PM -0500, Jeff Garzik wrote:
> Matt Mackall wrote:
> >/dev/random  kill unrolled SHA code
> >
> >Kill the unrolled SHA variants. In the future, we can use cryptoapi
> >for faster hash functions.
> >
> > tiny-mpm/drivers/char/random.c |  146 
> > 1 files changed, 146 deletions(-)
> >
> >diff -puN drivers/char/random.c~kill-sha-variants drivers/char/random.c
> >13:38:34.000000000 -0600
> >+++ tiny-mpm/drivers/char/random.c	2004-03-20 13:38:34.000000000 -0600
> >@@ -885,9 +885,6 @@ EXPORT_SYMBOL(add_disk_randomness);
> > #define HASH_BUFFER_SIZE 5
> > #define HASH_EXTRA_SIZE 80
> > 
> >-/* Various size/speed tradeoffs are available.  Choose 0..3. */
> >-#define SHA_CODE_SIZE 0
> 
> 
> So we go from "fast" to "I hope it gets faster in the future"?

No, we go from "moderately fast and dead code duplicated in /crypto"
to "same speed and one step closer to merging with /crypto". This bit
can be dropped for now, I've got the other bits deeper in my queue.

-- 
Matt Mackall : http://www.selenic.com : Linux development and consulting
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/