Re: [Swsusp-devel] Re: swsusp problems [was Re: Your opinion on the merge?]

[Jonathan Sambrook]

At 16:18 on Wed 24/03/04, pavel@xxxxxxx masquerading as 'Pavel Machek' wrote:
> Hi!
> 
> > > Except when it is not in syslog, because it was after atomic copy or
> > > before atomic copy back. swsusp is pretty unique in this respect.
> > >
> > 
> > And I would consider an error that happens after atomic copy critical. If
> > this happens all attempts to draw progress bar, etc. should be stopped and
> > suspend should probably abort as well.
> 
> Well, not all printks() are errors this hard. And at some points, it
> is no longer possible to abort (after pagedir is on disk, its okay to
> panic (machine will resume normally after that), but its not okay to
> simply return. You could fix signature then return, but it would be hard). 
> 
> > What happens if swsusp1 gets such an error during atomic phase? Will it
> > continue or abort? If it continues I would imagine user not noticing the
> > message it it flashes the split second before the box powers off. 
> 
> It continues. Fortunately powerdown takes enough time on most machines
> that messages can be readed ... 

> if you pay attetion.

Which is not a normal usage scenario.

Common scenario:

 suspend machine then go home/to bed


 BTW Pavel I'm not arguing that the code has to stay in without
 modification
 (e.g. massively stripped down or whatever). But this is one place where
 kernel code is a lot closer to Joe Enduser's awareness than is usually
 the case, so IMUO, the priorities shift.

 That said, this discussion seems to be necessary to refine what is
 necessary from what has been creatively evolved.

 Jonathan

> 								Pavel
> -- 
> Horseback riding is like software...
> ...vgf orggre jura vgf serr.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
                   
 Jonathan Sambrook 
Software  Developer 
 Designer  Servers

Attachment: pgp00000.pgp
Description: PGP signature