Re: [PATCH] barrier patch set

[Bartlomiej Zolnierkiewicz]

On Sunday 21 of March 2004 00:36, Johannes Stezenbach wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > On Saturday 20 of March 2004 12:36, Matthias Andree wrote:
> > > > Correct answer is: everything is fine, RTFM (man hdparm). ;-)
> > >
> > > Not everything is fine. hdparm documents -i returns inconsistent data.
> > > Most, but _NOT_ _EVERYTHING_ is cached: the multcount is updated, for
> > > instance. What is that good for? Mix & Match whatever is convenient?
> >
> > I'm aware of this bug - driver shouldn't modify drive->id.  Patches are
> > welcomed.
>
> Why? What's the reason for keeping out-of-date IDENTIFY data?

HDIO_GET_IDENTIFY ioctl which should die first.

> And what about ide_driveid_update()? Is it a bug that
> it exists?

It should just check/copy relevant bits from the new identify
(but without modifying drive->id).

> This is all too confusing for me :-(

Welcome in the wonderful world of IDE driver. ;-)

Bartlomiej

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/