Re: [PATCH] anobjrmap 5/6 anonmm

From: Rik van Riel
Date: Fri Mar 19 2004 - 11:17:53 EST


On Thu, 18 Mar 2004, Hugh Dickins wrote:

> + (*mapcount)--;

> + if (anonmm->mm && anonmm->mm->rss) {
> + referenced += page_referenced_one(
> + page, anonmm->mm, page->index, mapcount);
> + if (!*mapcount)
> + goto out;
> }

Brilliant little optimisation over what I thought Linus
proposed at first. This certainly removes the biggest
disadvantage I (and presumably Andrea) thought the mm
based reverse mapping would have !

I like this code a lot...

--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/