Re: 2.6.xx - linux/firmware.h - missing include

From: Russell King
Date: Fri Mar 19 2004 - 10:33:18 EST


On Fri, Mar 19, 2004 at 04:17:45PM +0100, Margit Schubert-While wrote:
> The prototype for request_firmware uses a struct device parameter.
> This is only defined if linux/device.h is included.
> Fix is simple : include linux/device.h in linux/firmware.h

That way leads to madness in the includes. firmware.h does not need
the definition of struct device, it only needs to know that struct
device exists.

You can do this via:

struct device;

before its use - this works much the same way as a function declaration
vs. function prototype.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/