Re: 2.6.4-mm2

From: Chris Mason
Date: Wed Mar 17 2004 - 19:29:59 EST


On Wed, 2004-03-17 at 19:13, Andrew Morton wrote:
> Chris Mason <mason@xxxxxxxx> wrote:
> >
> > On Wed, 2004-03-17 at 18:51, Andrew Morton wrote:
> > > Chris Mason <mason@xxxxxxxx> wrote:
> > > >
> > > > Looks good, but I'm still having problems convincing pagevec_lookup_tag
> > > > to return anything other than 0 when called from
> > > > wait_on_page_writeback_range (ext2, ext3, reiserfs). Any ideas?
> > >
> > > This might help. I'm testing this path now, so there may be more changes..
> > >
> >
> > Well, that's certainly a lot slower ;-)
>
> For once, that's good.
>
> > I've got a direct_read_under
> > round going. While you're at it, there's one more bug.
> >
> > The wbc struct used by filemap_fdatawrite doesn't initialize
> > wbc.nonblocking to zero. stack magic might give us a 1 there, leading
> > to an early exit from mpage_writepages even when doing a WB_SYNC_ALL.
>
> I hope not.
>

Yes, my brain wandered off for a bit. Seems like it's break time for
chris...good news is that direct_read_under is still running without
problems here.

-chris


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/