Re: Fixes for .cfi directives for x86_64 kgdb

[Andi Kleen]

On 17 Mar 2004 16:37:15 -0500
Jim Houston <jim.houston@xxxxxxxxxxx> wrote:

> 
> Hi Andi, Andrew, Amit,
> 
> The attached patch fixes the .cfi directives for the common_interrupt
> path for opteron.  It seems that the existing .cfi directives in this
> path only work by accident.
> 
> I spent yesterday decoding a stack by hand and looking at the
> dwarf unwind data using "readelf -wF".  I found that the  existing
> .cfi directives describe registers sharing the same stack addresses
> (not a good thing).
> 
> This patch makes the unwind data make sense and makes gdb/kgdb more
> likely to produce a useful stack traces.

Thanks. I applied it. The calling.h part gave rejects, but I applied it
by hand. It would be nice if you could check in the final kernel if I didn't
make a mistake.

-Andi


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/