Re: 2.6.5-rc1 SCSI + st regressions (was: Linux 2.6.5-rc1)

From: Mike Anderson
Date: Wed Mar 17 2004 - 16:48:50 EST


Kai Makisara [Kai.Makisara@xxxxxxxxxxx] wrote:
> if (!st_class_member) {
> printk(KERN_WARNING "st%d: class_simple_device_add failed\n",
> dev_num);

Could you change the if check to use IS_ERR(st_class_member) so in the
future if do_create_class_files return -E* we will not get a oops.

-andmike
--
Michael Anderson
andmike@xxxxxxxxxx

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/