Re: [PATCH] Re: 2.6.x BSD Process Accounting w/High UID

[Arthur Corliss]

On Sun, 7 Mar 2004, Tim Schmielau wrote:

> But the current tools are only broken for the few people using high UIDs
> (and generally on 64 bit archs, but that's a different story).

This is broken on x86 as well.  I guess I still have to question the logic of
logging bad data, even if you think the data is infrequent at best.  Keep in
mind that in my environment I'm not using high UIDs because I actually have
that many accounts, I'm using them because each employee uses their employee
ID as their UID, which simplifies management for me.  Again, this most likely
isn't typical, but it's not irrational, either.

> We shouldn't require people to recompile their userspace tools in the
> middle of a stable kernel series. (OK, 2.6 has just started, but we don't
> want to offend people upgrading from 2.4, either.)

I can understand this argument, and I would certainly agree for things that
are commonly used.  But given the state of the BSD accounting tools (a package
that hasn't had a public update since 1998, and which has non-high uid broken
bits in it as well) I would hazard a guess that the impacted users is going to
be minimal, at best.

> How about the patch below? It requires a change to userspace tools if you
> want to use high uids, but it dosn't break binary compatibility. It even
> allows userspace to check whether high UIDs are supported, and allows
> future incompatible format changes to be detected.

I like it, and the addition of ac_version is a great idea.  I might alter the
comment about 64-bit machines in acct.c, though.  32-bit UIDs affects 32-bit
machines as well.

> Well, they are not totally meaningless since we clip at the maximum
> representable value instead of wrapping around.

:-P I don't look at this any different than the byte-clipping we're doing with
UIDs.  If we're logging data that's wrong, then you can't do accurate
accounting, period.

	--Arthur Corliss
	  Bolverk's Lair -- http://arthur.corlissfamily.org/
	  Digital Mages -- http://www.digitalmages.com/
	  "Live Free or Die, the Only Way to Live" -- NH State Motto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/