Re: [linux-usb-devel] Re: [BUG] usblp_write spins forever after an error

From: Paulo Marques
Date: Fri Mar 05 2004 - 09:33:17 EST


David Woodhouse wrote:

On Thu, 2004-03-04 at 12:33 +0000, Paulo Marques wrote:

Yes, unfortunately it did went into 2.6.4-rc1. However it is already corrected in 2.6.4-rc2. Luckily it didn't went into any "non-rc" official release.

Please try 2.6.4-rc2, and check to see if the bug went away...


Seems to work; thanks. Does this need backporting to 2.4 too?



Unfortunately this isn't over yet.

I got suspicious about this bug fix, because I *did* test my patch before submitting it and the kernel that didn't work before, worked fine with my patch.

But now it seems that it is the other way around. After a few digging I found out the problem:

The application that I was testing with uses the usblp handle with non-blocking I/O .

So my patch does work for non-blocking I/O uses of the port, but wrecks the normal blocking mode.

I've already produced a version that works for both cases. I'll just clean it up a bit and submit it to 2.4 and 2.6 kernels.

--
Paulo Marques - www.grupopie.com
"In a world without walls and fences who needs windows and gates?"

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/