Re: [PATCH 2.4] sys_select() return error on bad file

From: Willy Tarreau
Date: Thu Mar 04 2004 - 09:02:57 EST


On Thu, Mar 04, 2004 at 10:20:41AM +0100, Armin Schindler wrote:

> retval cannot be used for that, it may get changed in the loop.

OK

> Anyway, I don't see how your proposal would do better performance?
> My patch just adds a new variable on the stack, which should not make any
> difference in performance. And later, it is the same if the new or another
> variable gets changed or checked.

It is possible that in current code the, compiler is able to allocate a
register for each variable used inside the loop, while it may not be able
anymore with an additionnal variable. But that's just speculation anyway.

Cheers,
Willy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/