Re: [PATCH] ppc32: macserial.c missing variable declaration

[Linus Torvalds]

On Wed, 3 Mar 2004, Wojciech 'Sas' Cieciwa wrote:
>  {
>  	struct mac_serial * info = (struct mac_serial *)tty->driver_data;
>  	unsigned char control, status;
> +	unsigned int cmd;
>  	unsigned long flags;
>  
>  #ifdef CONFIG_KGDB

This can't be right. Those variables are never initialized anywhere.

The usage of 'cmd' should either be removed entirely, or it should be 
passed in as an argument, it looks like. In the meantime, it's better to 
have code that doesn't compile than code that compiles but can't possibly 
do anything sane.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/