Re: [start_kernel] Suggest to move parse_args() before trap_init()

[Andi Kleen]

Andrew Morton <akpm@xxxxxxxx> writes:

> I think the only problem with this is if we get a fault during
> parse_args(), the kernel flies off into outer space.  So you lose some
> debuggability when using an early console.
> 
> But 2.4 does trap_init() after parse_args() and nobody has complained, as
> did 2.6 until recently.  So the change is probably OK.

The standard way to fix this is to add an explicit check for lapic
to the early argument parsing in setup.c (but keep the __setup so that
no unknown argument is reported).

I think that's better than moving it and getting possible bugs that cannot
even be catched with early printk.

Another way that i've considered on x86-64 for 2.7 at least is a special
__early_setup() for this

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/