Re: [PATCH] Add a MODULE_VERSION macro

[Rusty Russell]

In message <CA71EA605D@xxxxxxxxxxxxxxxx> you write:
> >  ifneq ($(filter-out $(modules),$(__modules)),)
> > +  $(warning Trouble: $(__modules) )
> >    $(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
> >    $(warning     do not complain if something goes wrong.)
> >  endif
> 
> Hi Rusty,
>   what is this line supposed to do, except making it impossible
> to build kernel modules in temporary directories? Now when I build
> out-of-tree modules, I get 'Trouble:' followed by approximate 16000
> characters listing paths to all modules I have in kernel

Patch below: does it help?

Rusty
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.6.4-rc1-bk1/scripts/Makefile.modpost tmp/scripts/Makefile.modpost
--- linux-2.6.4-rc1-bk1/scripts/Makefile.modpost	2004-02-29 19:11:38.000000000 +1100
+++ tmp/scripts/Makefile.modpost	2004-03-01 16:40:33.000000000 +1100
@@ -14,7 +14,7 @@ __modules := $(shell head -q -n1 /dev/nu
 modules := $(patsubst %.o,%.ko,$(wildcard $(__modules:.ko=.o)))
 
 ifneq ($(filter-out $(modules),$(__modules)),)
-  $(warning Trouble: $(__modules) )
+  $(warning Trouble: $(filter-out $(modules),$(__modules)))
   $(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
   $(warning     do not complain if something goes wrong.)
 endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/