Re: new driver (hvcs) review request and sysfs questions
From: Dave Boutcher
Date: Tue Feb 24 2004 - 22:13:27 EST
On Tue, 24 Feb 2004 17:28:45 -0800, Greg KH <greg@xxxxxxxxx> wrote:
On Tue, Feb 24, 2004 at 06:00:26PM -0600, Ryan Arnold wrote:
An example of the vio bus's "devices" sysfs directory is shown below.
Pow5:/sys/bus/vio/devices # ls
. l-lan@3000000c l-lan@30000010 vty-server@30000004
.. l-lan@3000000d rtc@4001 vty@30000000
IBM,sp@4000 l-lan@3000000e v-scsi@30000002
l-lan@3000000b l-lan@3000000f vty-server@30000003
At first glance, why are you using text strings as part of your bus ids?
Bus ids must be unique, so it looks like you can do this by just using
the number after the '@' character, right?
That naming convention (e.g. l-lan@3000000c) is what is defined in the
IEEE Standard for Boot (Initialization Configuration) Firmware spec, and
what gets presented by Open Firmware. It is what has been used in things
like /proc/device-tree on the Power platforms forever, and thus was
carried over into the sysfs definitions.
It is also true that it is unlike the representation of most other things
in sysfs, so perhaps this is the time to change before it gets too baked
into things.
Dave B
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/