Re: [ACPI] acpi problem with nforce motherboards and ethernet

[Luis Miguel García]

Maciej W. Rozycki wrote:

> On Thu, 5 Feb 2004, Andrew Morton wrote:
>
>  
>
> > > By the way, is anyone involved in solving the IO-APIC thing in nforce 
> > > motherboards? Anyone trying a different approach? Anyone contacting 
> > > nvidia about this problem?
> > >      
> > As far as I know, we're dead in the water on these problems.
> >    
>
> Not necessarily. :-)
>
>  
>
> > Here's one:
> >
> >
> > [x86] do not wrongly override mp_ExtINT IRQ
> >
> > From: Mathieu <cheuche+lkml@xxxxxxx>.
> >
> > With this patch timer IRQ0 is correctly set to IO-APIC-edge
> > (not XT-PIC) on nForce2 boards when using APIC and ACPI.
> >
> > arch/i386/kernel/mpparse.c |    3 ++-
> > 1 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff -puN arch/i386/kernel/mpparse.c~nforce2-apic arch/i386/kernel/mpparse.c
> > --- linux-2.6.0-test11/arch/i386/kernel/mpparse.c~nforce2-apic	2003-12-08 00:12:25.782597272 +0100
> > +++ linux-2.6.0-test11-root/arch/i386/kernel/mpparse.c	2003-12-08 00:12:25.786596664 +0100
> > @@ -962,7 +962,8 @@ void __init mp_override_legacy_irq (
> > 	 */
> > 	for (i = 0; i < mp_irq_entries; i++) {
> > 		if ((mp_irqs[i].mpc_dstapic == intsrc.mpc_dstapic) 
> > -			&& (mp_irqs[i].mpc_srcbusirq == intsrc.mpc_srcbusirq)) {
> > +			&& (mp_irqs[i].mpc_srcbusirq == intsrc.mpc_srcbusirq)
> > +			&& (mp_irqs[i].mpc_irqtype == intsrc.mpc_irqtype)) {
> > 			mp_irqs[i] = intsrc;
> > 			found = 1;
> > 			break;
> >    
>
> That's not the right fix.  There's a bug in Linux's ACPI IRQ setup as
> I've discovered by comparing the code to the spec.  Here's a patch I sent
> in December both to the LKML and the ACPI maintainer.  The feedback from
> the list was positive, but the maintainer didn't bother to comment.
>
> I haven't pushed the patch more firmly, because the MIPS port is my
> priority and I don't even have any ACPI-aware equipment.
>
> Maciej
>
>  
Can you send us the specific patch or at least telling us if you're 
going to push it?

Thanks a lot for the fix ;)

LuisMi Garcia
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/