Re: [PATCH] PCI / OF linkage in sysfs

[Benjamin Herrenschmidt]

On Thu, 2004-02-05 at 11:04, Linus Torvalds wrote:

> I think that I personally would be a lot happier with the situation if it 
> wasn't that PCI had magic knowledge about OF in particular.  In other 
> words, you'd likely be able to sell me on an idea where the PCI layer just 
> knows about "let the firmware install a few files here", but is totally 
> firmware-agnostic per se.
> 
> In other words, you migth just rename the "OF" functionality as "platform" 
> functionality, and add dummy (empty) platform handlers for the other 
> platforms (eg BIOS/EFI whatever). Maybe some day EFI will want to have a 
> similar pointer..
> 
> So while I'd hate to have the PCI layer start having to learn details of 
> all the platforms out there, I don't think it's necessarily wrong that the 
> PCI layer knows about the _concept_ of a platform, as long as it doesn't 
> get too specific.
> 
> Would that suit your needs?

What about adding a pcibios_add_platform_entries(device) called by
pci_sysfs then ? By default an empty inline on asm/* and on PPC,
I can add my devspec without having OF-aware code in drivers/pci

Also, if you prefer a different name for "devspec", speak up now ;)

I can still change the name in the macio devices too, nothing uses
them right now and I expect things that will be fixed to use them
to rely on 2.6.3 minimum.

Ben.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/