Re: 2.6 probe.c "pcibus_class" Device Class, release function

[Greg KH]

On Tue, Feb 03, 2004 at 05:31:42PM -0800, Matthew Dobson wrote:
> John Rose wrote:
> >The function release_pcibus_dev() in probe.c defines the release procedure 
> >for
> >device class pcibus_class.  I want to suggest that this function be 
> >scrapped :)
> >
> >This release function is called in the code path of 
> >class_device_unregister().
> >The pcibus_class devices aren't currently unregistered anywhere, from what 
> >I
> >can tell, so this release function is currently unused.  The runtime 
> >removal of
> >PCI buses from logical partitions on PPC64 requires the unregistration of 
> >these
> >class devices.  The natural place to do this IMHO is in 
> >pci_remove_bus_device()
> >in remove.c.  
> 
> You're right that the class device isn't currently unregistered, and 
> that was an oversight in the patch I originally sent.  Attatched is a 
> patch that remedies that situation.  pci_remove_bus_device() *is* the 
> natural place to unregister the class_dev, and that's just what the 
> patch does.

Thanks, I've applied this patch to my trees and will send off to Linus
in the next round of PCI patches.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/