Re: [PATCH] DVB compile fix

From: Randy.Dunlap
Date: Mon Feb 02 2004 - 12:18:11 EST


On Mon, 2 Feb 2004 17:10:40 +0100 (MET) Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:

|
| Never include <asm/delay.h> directly
|
| --- linux-2.6.2-rc3/drivers/media/dvb/frontends/dst.c 2004-01-06 15:29:13.000000000 +0100
| +++ linux-m68k-2.6.2-rc3/drivers/media/dvb/frontends/dst.c 2004-01-10 17:10:35.000000000 +0100
| @@ -28,8 +28,8 @@
| #include <linux/string.h>
| #include <linux/slab.h>
| #include <linux/vmalloc.h>
| +#include <linux/delay.h>
| #include <asm/div64.h>
| -#include <asm/delay.h>


You could modify <asm/delay.h> the way that
include/asm-i386/rwsem.h is done so that this won't continue
to happen:

#ifndef _LINUX_RWSEM_H
#error "please don't include asm/rwsem.h directly, use linux/rwsem.h instead"
#endif

--
~Randy
kernel-janitors project: http://janitor.kernelnewbies.org/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/