Re: 2.6.2-rc2-mm2

[Andrew Morton]

Arjan van de Ven <arjanv@xxxxxxxxxx> wrote:
>
> 
> directly calling sys_ANYTHING sounds really wrong to me...
> 

It's a philosophical thing.  Is a kernel thread like a user process which
happens to be running from the kernel or it is a piece of mainline kernel
code which happens to have its own execution context?  I rather favour the
latter...

In this case it looks like it will just happen to work, because
nfsd_setuser() is executed by nfsd, and kernel threads are allowed to do
copy_from_user() with the source in kernel memory.  ick.

Tim, I do think it would be neater to add another entry point in sys.c for
nfsd and just do a memcpy.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/