Re: mm/slab.c: linux 2.6.1 fix 2 unguarded kmalloc and a PAGE_SHIFT

[Manfred Spraul]

Hi Walter,

> this fixes catches 2 unguarded kmallocs() and changes a statement so that PAGE_SHIFT \
> > 20 causes a warning.  At least sparc64 is prepared for a  PAGE_SHIFT >20.
>  
Why should a page shift above 20 generate a warning?

The two unguarded kmallocs are obivously wrong, but I'd prefer to guard 
them with __GFP_NOFAIL.

--
   Manfred

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/