Re: [PATCH] [2.4] forcedeth network driver

[Vojtech Pavlik]

On Sat, Jan 24, 2004 at 03:21:26PM -0500, Jeff Garzik wrote:
> >>>+static int alloc_rx(struct net_device *dev)
> >>>+{
> >[snip]
> >>>+    return 0;
> >>>+}
> >>
> >>skb_reserve() seems to be missing
> >>
> >Do you have specs that show that all nForce versions support unaligned 
> >buffers? skb_reserve is a performance feature, I don't want to add it 
> >yet. Testing that it works is on our TODO list.
> 
> hmmmm, is nForce ever found on non-x86 boxes?  I would think that 
> skb_reserve might be -required- for some platforms.

AMD64 and PPC64 as far as I know. But you may consider the first one
still a x86 box.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/