Re: logic error in XFS

[Steve Lord]

Måns Rullgård wrote:

> davej@xxxxxxxxxx writes:
>
>  
>
> > Yet another misplaced ! by the looks..
> >    
>
> Sure looks like it.  When is this code encountered?
>  

File system recovery, it is going to insert buffer items out of order in
the recovery sequence which means replay could be out of order.
Its been there since around September by the look of it. Definitely should
be the other way around. Thanks Dave.

Steve

>  
>
> > diff -urpN --exclude-from=/home/davej/.exclude bk-linus/fs/xfs/xfs_log_recover.c linux-2.5/fs/xfs/xfs_log_recover.c
> > --- bk-linus/fs/xfs/xfs_log_recover.c	2003-10-09 01:01:24.000000000 +0100
> > +++ linux-2.5/fs/xfs/xfs_log_recover.c	2004-01-14 07:06:40.000000000 +0000
> > @@ -1553,7 +1553,7 @@ xlog_recover_reorder_trans(
> > 		case XFS_LI_BUF:
> > 		case XFS_LI_6_1_BUF:
> > 		case XFS_LI_5_3_BUF:
> > -			if ((!flags & XFS_BLI_CANCEL)) {
> > +			if (!(flags & XFS_BLI_CANCEL)) {
> > 				xlog_recover_insert_item_frontq(&trans->r_itemq,
> > 								itemq);
> > 				break;
> >    
>
>  


--
Steve Lord <Stephen.Lord@xxxxxxxx>                Tel: 952-882-0619

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/