logic error in aty128fb

From: davej
Date: Fri Jan 23 2004 - 02:10:49 EST


Negate the expression not the register seems more sensible?

Dave

diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/video/aty/aty128fb.c linux-2.5/drivers/video/aty/aty128fb.c
--- bk-linus/drivers/video/aty/aty128fb.c 2003-10-15 05:00:42.000000000 +0100
+++ linux-2.5/drivers/video/aty/aty128fb.c 2004-01-14 07:07:10.000000000 +0000
@@ -2102,7 +2102,7 @@ aty128_set_backlight_enable(int on, int
reg |= LVDS_BL_MOD_EN | LVDS_BLON;
if (on && level > BACKLIGHT_OFF) {
reg |= LVDS_DIGION;
- if (!reg & LVDS_ON) {
+ if (!(reg & LVDS_ON)) {
reg &= ~LVDS_BLON;
aty_st_le32(LVDS_GEN_CNTL, reg);
(void)aty_ld_le32(LVDS_GEN_CNTL);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/