2.6.2-rc1-mm1 and Fedora gcc-3.5ssa - memcmp issues

[Valdis . Kletnieks]

Tried building with Fedora gcc-ssa, and got this on 'make modules_install':

if [ -r System.map ]; then /sbin/depmod -ae -F System.map  2.6.2-rc1-mm1; fi
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/fs/nfsd/nfsd.ko needs unknown symbol memcmp
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/fs/nfs/nfs.ko needs unknown symbol memcmp
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/fs/msdos/msdos.ko needs unknown symbol memcmp
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/fs/lockd/lockd.ko needs unknown symbol memcmp
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/fs/fat/fat.ko needs unknown symbol memcmp
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/net/ipv6/netfilter/ip6t_mac.ko needs unknown symbol memcmp
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/net/sunrpc/sunrpc.ko needs unknown symbol memcmp
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/net/sunrpc/auth_gss/rpcsec_gss_krb5.ko needs unknown symbol memcmp
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/net/sunrpc/auth_gss/auth_rpcgss.ko needs unknown symbol memcmp
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/net/ipv4/netfilter/ipt_recent.ko needs unknown symbol memcmp
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/net/ipv4/netfilter/ipt_mac.ko needs unknown symbol memcmp
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/net/ipv4/netfilter/ip_conntrack_irc.ko needs unknown symbol memcmp
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/drivers/pcmcia/pcmcia_core.ko needs unknown symbol memcmp
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/drivers/net/slhc.ko needs unknown symbol memcmp
WARNING: /lib/modules/2.6.2-rc1-mm1/kernel/drivers/char/i8k.ko needs unknown symbol memcmp


The cause?  A chain of events:

1) Inlining didn't happen for at least one case in the failing modules.
2) There wasn't an EXPORT_SYMBOL.
3) Even once that got added, it didn't help because a "#define memcmp __buildin_memcmp"
caused the wrong symbol to get exported:

% nm lib/string.o|grep memcmp
00000000 r __kstrtab___builtin_memcmp
00000000 r __ksymtab___builtin_memcmp
00000217 T memcmp
% nm lib/string.o|grep strlcpy
00000027 r __kstrtab_strlcpy
00000020 r __ksymtab_strlcpy
00000325 T strlcpy

Patch to fix memcmp attached - with it, the depmod succeeds.

Should I do the similar thing for *all* the things in lib/string.c?  Only some
of the functions have EXPORT_SYMBOL, and various releases of gcc *may*
have different __builtin_foo lists.

--- linux-2.6.2-rc1-mm1/lib/string.c.dist	2004-01-22 17:20:00.859598882 -0500
+++ linux-2.6.2-rc1-mm1/lib/string.c	2004-01-22 17:29:43.316730389 -0500
@@ -501,6 +501,9 @@
 #endif
 
 #ifndef __HAVE_ARCH_MEMCMP
+#ifdef memcmp
+#undef memcmp
+#endif
 /**
  * memcmp - Compare two areas of memory
  * @cs: One area of memory
@@ -517,6 +520,7 @@
 			break;
 	return res;
 }
+EXPORT_SYMBOL(memcmp);
 #endif
 
 #ifndef __HAVE_ARCH_MEMSCAN

Attachment: pgp00000.pgp
Description: PGP signature