Re: limit-timer_pm-printk-storms.patch

From: Dominik Brodowski
Date: Wed Jan 21 2004 - 03:28:50 EST


On Tue, Jan 20, 2004 at 11:57:51AM -0800, Andrew Morton wrote:
> Bongani Hlope <bonganilinux@xxxxxxxxxx> wrote:
> >
> > This patch has been inspired by the limit-IO-error-printk-storms patch. On my PII when I enable
> > CONFIG_X86_PM_TIMER this gets called a lot of times, I guess my VIA chipset is too broken to play with this.
> >
> > <example>
> > ...
> > Jan 19 04:21:46 bongani kernel: bad pmtmr read: (15567390, 15567423, 15567393)
> > Jan 19 04:21:46 bongani kernel: bad pmtmr read: (1746710, 1746719, 1746713)
> > Jan 19 04:21:47 bongani kernel: bad pmtmr read: (2239982, 2239999, 2239986)
>
> Does the PM timer actually do the right thing once these printk's are
> suppressed?

Just recognized my backup notebook, a Pentium III / Intel 440-BX-AGPset
does the same thing -- the pmtmr readings are always quite close to each
other, but not linear.

However, overall the PM timer _does_ the right thing all the time [it always
did the right thing on that system, as that's where the original patch was
created....]

Dominik

Attachment: pgp00000.pgp
Description: PGP signature