Re: struct task_struct -> task_t

[Albert Cahalan]

Martin Hicks writes:
> On Mon, Jan 19, 2004 at 10:24:34PM +0000, viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx wrote:
>> On Mon, Jan 19, 2004 at 02:17:57PM -0800, john moser wrote:

>>> It has come to my attention that in some places
>>> in the kernel, 'struct task_struct' is used; and
>>> in others, 'task_t' is used.  Also, 'task_t' is
>>> 'typedef struct task_struct task_t;'.
>>>
>>> I made a small script to change around as much
>>> as I could so that everything uses task_t,
>>
>> What the fsck for?  If anything, the opposite
>> (and removal of that typedef) would be preferable.
>
> John,
>
> As Al is trying to point out, we try to discourage
> the use of typedefs in the kernel.  It is much
> easier to see that blah_t is really a struct if
> we always use 'struct blah'.

That's no good for variable usage. We don't
write "struct current".

You're giving the argument for Hungarian
notation. Not that I'd suggest it, but that
is where your argument leads.

IMHO, we type too much already.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/