Re: i386/mm and openwall change

[Linus Torvalds]

On Wed, 21 Jan 2004, Maciej Zenczykowski wrote:
> 
> If it doesn't matter why set the bit at all?  If we do set the least
> significant bit this is obviously because it shouldn't be zero (i.e. it
> doesn't matter as long as it's boolean true), if so then why does ow set
> it to zero in this case.  Obviously this is somehow _weird_...

The error code is _not_ a boolean. It's several bits, and it so happens 
that only the low bit matters for kernel space accesses. And it doesn't 
actually matter whether it is set (2.6.x) or not (2.4.x), it should just 
be fixed.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/