i386/mm and openwall change

From: Maciej Zenczykowski
Date: Tue Jan 20 2004 - 10:30:16 EST


Linux 2.4.24 contains in arch/i386/mm/fault.c [around line 270]
the following code.

tsk->thread.error_code = error_code;

Openwall 2.4.24-ow1 changes (fixes?) this to:

if (address < TASK_SIZE)
tsk->thread.error_code = error_code;
else
tsk->thread.error_code = 0;

While Linux 2.4.25-pre6 contains:

/* Kernel addresses are always protection faults */
tsk->thread.error_code = error_code | (address >= TASK_SIZE);

I'm assuming this means the openwall change was an error?

Cheers,
MaZe.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/