Re: [patch] increse MAX_NR_MEMBLKS to same as MAX_NUMNODES on NUMA

[Martin J. Bligh]

--Jesse Barnes <jbarnes@xxxxxxx> wrote (on Monday, January 19, 2004 18:24:52 -0800):

> On Mon, Jan 19, 2004 at 04:45:35PM -0600, Jack Steiner wrote:
>> On Mon, Jan 19, 2004 at 12:08:04PM -0800, Martin J. Bligh wrote:
>> > > Since we now support # of CPUs > BITS_PER_LONG with cpumask_t it would
>> > > be nice to be able to support more than BITS_PER_LONG memory blocks.
>> > 
>> > Nothing uses them. We're probably better off just removing them altogether.
>> 
>> I dont understand.
>> node_memblk[] is used on IA64 in arch/ia64/mm/discontig.c (& other places too).
> 
> I think Martin is referring to the memblk_*line() functions and the fact
> that memblks are exported via sysfs to userspace.  That API hasn't
> proven very useful so far since it's really waiting for memory hot
> add/remove.  Of course, we'll still need structures to support that for
> the low level arch specific discontig code, so any patch that killed
> memblks in sysfs and elsewhere would have to take that into account...
> (In particular, node_memblk[] is filled out by the ACPI SRAT parsing
> code and use for discontig init and physical->node id conversion.)

Phew ;-) 
Maybe I'll go ahead and delete it quickly ... ;-)

M.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/