Re: [PATCH 2.6.1] Net device error logging

From: Andrew Morton
Date: Mon Jan 19 2004 - 21:57:18 EST


Jim Keniston <jkenisto@xxxxxxxxxx> wrote:
>
> The enclosed patch implements the netdev_* error-logging macros for
> network drivers.

Looks OK to me.

But it does make one wonder whether we'll soon see standalone patches for
scsi_printk(), pci_bridge_printk(), random_other_subsystem_printk(), ...?

Or is it intended that the backend logging code will be implemented mainly
in terms of the `struct device'? So netdev_printk() will be a bit of
netdev-specific boilerplate which then calls into a more generic
device_printk()?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/