Re: [patch] v4l-05 add infrared remote support

[Rusty Russell]

In message <20040115115611.GA16266@xxxxxxxxxxx> you write:
> +static int repeat = 1;
> +MODULE_PARM(repeat,"i");
> +MODULE_PARM_DESC(repeat,"auto-repeat for IR keys (default: on)");
> +
> +static int debug = 0;    /* debug level (0,1,2) */
> +MODULE_PARM(debug,"i");

Please replace the MODULE_PARM lines with the modern form:

	module_param(repeat, bool, 0644);
	module_param(debug, int, 0644);

(I'm assuming that it's safe to change repeat and debug on the fly
without any locking.  If not, change to 0444).

For more information, see include/linux/moduleparam.h.

Thanks!
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/