Re: [PATCH] ppc64: VIO support, from Dave Boutcher, Hollis Blanchard and Santiago Leon

From: Greg KH
Date: Mon Jan 19 2004 - 18:05:11 EST


On Mon, Jan 19, 2004 at 10:49:53PM +0000, Christoph Hellwig wrote:
> On Mon, Jan 19, 2004 at 02:32:30PM -0800, Greg KH wrote:
> > Ick ick ick. I thought you all were not going to add this function, but
> > just use vio_register_driver() on it's own? Loading a driver should not
> > depend on CONFIG_HOTPLUG, as we now have different ways we can bind
> > drivers to devices after they are loaded (see the new_id stuff for pci
> > devices as an example.)
>
> I wonder why this code got merged at all. Half of it could easily be
> scrapped by using the driver model properly.

Which is another point. I thought I saw a port of this code to the
driver model for 2.6 on the ppc mailing list. Why this old code?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/