Re: 2.6.1-mm4: ALSA es1968 DMA alloc problem

[Takashi Iwai]

Hi,

At Mon, 19 Jan 2004 17:43:22 +0100,
Arjan van de Ven wrote:
> 
> [1  <text/plain (quoted-printable)>]
> On Mon, 2004-01-19 at 17:29, Takashi Iwai wrote:
> > At Sat, 17 Jan 2004 17:10:13 +0100,
> 
> 
> all throughout the patch:
> pci_set_dma_mask() and friends need their return value checked!

it does check.  the patch replaces the code like

	if (! pci_dma_support(pci, XXXX))
		error;
	pci_set_dma_mask(pci, XXXX);

with
	if (pci_dma_set_mask(pci, XXXX))
		error;

(there is one place which doesn't check, but it's in the resume
 callback.)

the problem is that in the former version only
pci_set_consistent_dma_mask() was called without pci_dma_set_mask().
apparently, this doesn't work properly.


ciao,

Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/