Re: 2.6.1-mm4

[Rusty Russell]

On Sun, 18 Jan 2004 00:17:08 -0800
Andrew Morton <akpm@xxxxxxxx> wrote:

> Presumably, recent gcc's remove the variable altogether and just expand the
> constant inline.  When the central module code checks for the parameter's
> existence in the module's symbol table it errors out.

MODULE_PARM considered harmful.

Unfortunately, there's no easy way of fixing this, since MODULE_PARM()
is often used on variables which aren't declared yet 8(.  (I tried this
in an early patch).

Migrating to module_param() is the Right Thing here IMHO, which actually
takes the damn address,

Rusty.
-- 
   there are those who do and those who hang on and you don't see too
   many doers quoting their contemporaries.  -- Larry McVoy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/