Re: [3/3] 2.6 broken serial drivers

[Russell King]

On Tue, Jan 13, 2004 at 09:10:23PM +0000, Russell King wrote:
> On Tue, Jan 13, 2004 at 12:21:15PM -0800, Andrew Morton wrote:
> > Russell King <rmk+lkml@xxxxxxxxxxxxxxxx> wrote:
> > >
> > > --- 1.14/drivers/net/wan/pc300_tty.c	Thu Sep 11 18:40:53 2003
> > > +++ edited/drivers/net/wan/pc300_tty.c	Tue Jan 13 14:42:34 2004
> > > @@ -583,6 +583,14 @@
> > >  	CPC_TTY_DBG("%s: IOCTL cmd %x\n",cpc_tty->name,cmd);
> > >  	
> > >  	switch (cmd) { 
> > > +#error This is broken.  See comments.
> > 
> > Grumble.  This breaks allmodconfig.  #warning, please.
> 
> Probably far better to make all these drivers depend on BROKEN unless
> one of the authors speaks up.

Ok, no one spoke, so here's the patch to mark this driver broken:

===== drivers/net/wan/Kconfig 1.16 vs edited =====
--- 1.16/drivers/net/wan/Kconfig	Tue Dec 30 08:45:02 2003
+++ edited/drivers/net/wan/Kconfig	Sun Jan 18 16:15:19 2004
@@ -367,7 +367,7 @@
 
 config PC300_MLPPP
 	bool "Cyclades-PC300 MLPPP support"
-	depends on PC300 && PPP_MULTILINK && PPP_SYNC_TTY && HDLC_PPP
+	depends on PC300 && PPP_MULTILINK && PPP_SYNC_TTY && HDLC_PPP && BROKEN
 	help
 	  Say 'Y' to this option if you are planning to use Multilink PPP over the
 	  PC300 synchronous communication boards.


-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/