Re: [RFC] kill sleep_on

From: Manfred Spraul
Date: Sun Jan 18 2004 - 03:19:44 EST


Trond Myklebust wrote:

I'm not sure that taking inode->i_sem would be much of an improvement.
Both th BKL and the inode semaphore seem superfluous to me in this
situation.

I think the purpose of i_sem or lock_kernel is to protect the file pointer. Most local filesystems use i_sem, it's noticably faster - global vs. per-object locking.
Btw, generic_mapping_read should also lock it's accesses to f_pos: right now it reads and writes f_pos without any locking...

--
Manfred

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/