Re: [RFC] kill sleep_on

From: Andrew Morton
Date: Sun Jan 18 2004 - 01:42:13 EST


David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:
>
> On Sat, 2004-01-17 at 20:10 +0000,
> viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx wrote:
> > AFAICS, _all_ uses of sleep_on() in drivers are broken in one way or another
> > and BKL won't help them.
>
> I think ext3 and nfs get away with it at the moment by using the BKL. It
> does want fixing though.

ext3 had all its sleep_on()s and lock_kernel()s eradicated ages ago. In
2.4 it uses sleep_on()s and lock_kernel() makes that safe.

It would be nice to fix up the lock_kernel()s in the NFS client: SMP lock
contention is quite high in there.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/