Re: Linux 2.4.25-pre5

[Andrew Morton]

David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:
>
> ===== fs/inode.c 1.48 vs edited =====
>  --- 1.48/fs/inode.c	Wed Jan 14 20:51:18 2004
>  +++ edited/fs/inode.c	Fri Jan 16 07:43:14 2004
>  @@ -96,6 +96,7 @@
>   	if (inode) {
>   		struct address_space * const mapping = &inode->i_data;
>   
>  +		init_waitqueue_head(&inode->i_wait);
>   		inode->i_sb = sb;
>   		inode->i_dev = sb->s_dev;
>   		inode->i_blkbits = sb->s_blocksize_bits;
>  @@ -147,7 +148,6 @@
>   
>   void __inode_init_once(struct inode *inode)
>   {
>  -	init_waitqueue_head(&inode->i_wait);
>   	INIT_LIST_HEAD(&inode->i_hash);
>   	INIT_LIST_HEAD(&inode->i_data.clean_pages);
>   	INIT_LIST_HEAD(&inode->i_data.dirty_pages);

Really, the init_waitqueue_head() should be done prior to putting the inode
back into slab.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/