Re: netpoll bug - kgdboe on x86_64

[Pavel Machek]

Hi!

[Hmm, nice return address, Jim]

> I'm trying to get kgdboe working on x86_64.  I noticed that
> netpoll_rx is calling the rx_hook with negative values for the length.
> The attached patch fixes the problem. 

I was able to make -mm stuff work on i386, and there were not any
strange problems. (Hope this encourages you :-)



> Jim Houston - Concurrent Computer Corp.
> 
> ---
> 
> --- 2.6.1-rc1-mm2.orig/net/core/netpoll.c	2004-01-05 13:15:31.000000000 -0500
> +++ 2.6.1-rc1-mm2/net/core/netpoll.c	2004-01-13 18:58:09.311479928 -0500
> @@ -400,7 +400,7 @@ int netpoll_rx(struct sk_buff *skb)
>  
>  		if (np->rx_hook)
>  			np->rx_hook(np, ntohs(uh->source),
> -				    (char *)(uh+1), ulen-sizeof(uh)-4);
> +				    (char *)(uh+1), ulen-sizeof(struct udphdr));
>  
>  		return 1;
>  	}

-- 
Horseback riding is like software...
...vgf orggre jura vgf serr.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/