Re: Cleanups for powernow-k8

[Pavel Machek]

Hi!

>  > and is way too verbose.
> 
> I agree that something like that output belongs more in x86info,
> or a standalone tool, but I think Paul wanted to keep debugging stuff
> there for the time being. Maybe silence it, and have it enabled
> with a 'debug' module param ? Paul ?

I made sure all the info is still there in dmesg, just on less lines.

>  > @@ -637,6 +629,7 @@
>  >  		}
>  >  
>  >  		if ((numps <= 1) || (batps <= 1)) {
>  > +			/* FIXME: Is this right? I can see one state on battery, two states total as an usefull config */
>  >  			printk(KERN_ERR PFX "only 1 p-state to transition\n");
>  >  			return -ENODEV;
>  >  		}
>  > the test probably should be numps <= 1 only, but it does not matter as
>  > we force numps = batps]
> 
> 1 state on battery sounds odd. Buggy BIOS ?

No if you have 1 state on battery but two on AC power. That way you
*have* to be low power on battery, but can select low or high on
AC... Ugly hardware, but Intel done this before, and it kind-of makes
sense.
								Pavel

-- 
When do you have heart between your knees?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/