Re: [linux-usb-devel] Re: USB hangs

From: Oliver Neukum
Date: Mon Jan 12 2004 - 03:38:59 EST


Am Montag, 12. Januar 2004 08:39 schrieb Matthew Dharm:
> On Sun, Jan 11, 2004 at 08:11:58PM -0800, David Brownell wrote:
> >
> > >>> Plus I'd
> > >>>argue PF_MEMALLOC is a better solution anyway.
> > >>
> > >>It certainly seems like a more comprehensive fix for that
> > >>particular class of problems! :)
> > >
> > >
> > >Is it really more comprehensive? As I see it, it will only affect code
> > >executed in the context of the usb-storage thread. But, what about code
> > >which is invoked in tasklets or other contexts?
> >
> > Isn't it true that only that thread is allowed to
> > submit usb-storage i/o requests?
>
> That's very true.
>
> What I'm concerned about is the downstream effects of a usb_submit_urb() or
> the corresponding scatter-gather equivalents.

In 2.4 they all run in interrupt or thread context IIRC.
Problematic is the SCSI error handling thread. It can call usb_reset_device()
which calls down and does allocations.
Does that thread also do the PF_MEMALLOC trick?

Regards
Oliver


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/