Re: [PATCH] 2.6.1-rc2 ide barrier support

From: Jens Axboe
Date: Fri Jan 09 2004 - 02:27:47 EST


On Fri, Jan 09 2004, Benjamin Herrenschmidt wrote:
>
> > + char special_buf[8]; /* private command buffer */
>
> Why not put that in struct drive instead ? You must be a bit more
> careful on the lifetime, but it's less bloat, there are much less
> instances of struct drive than struct request :)

Hmm? It _is_ in struct drive :-). It could be put in hwgroup actually,
but I felt it was cleaner in drive (and easier to manage).

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/