Re: PATCH: Fix support for wide consoles in vt.c andinclude/linux/selection.h

From: Benjamin Herrenschmidt
Date: Fri Jan 09 2004 - 00:30:43 EST


On Fri, 2004-01-09 at 15:19, Nigel Cunningham wrote:
> Hi.
>
> In implementing a 'nice' display for Software Suspend, some users with
> wide VTs reported problems with distortion. These changes from signed to
> unsigned int/char fixed the issue and have been tested for around a year
> (guesstimate).
>
> The only other user of getconsxy is vc_screen.c. It might benefit from
> matching changes, although the users who reported the problem to me said
> nothing about other issues with their displays, so far as I recall.
>
> To actually use the functions from Suspend, the functions also had to be
> made non-static. Of course I could make this into 2 patches if desired.

Also make sure you grab the console semaphore when doing those things,
or recent 2.6's (at least -mm) will probably bark on you :)

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/