RE: [PATCH] LSI Logic MegaRAID3 PCI ID [Was: MegaRAID on AMD64under 2.6.1]

From: Chris Meadors
Date: Thu Jan 08 2004 - 17:04:44 EST


On Thu, 2004-01-08 at 16:38, Mukker, Atul wrote:
> I have not followed this thread completly yet but both
> PCI_DEVICE_ID_MEGARAID and PCI_DEVICE_ID_MEGARAID3 are valid and both should
> be present. Look for their definitions in the header file or pci_ids.h

Yes, both of those are valid device IDs (which is probably why the
dropped 3 didn't get noticed right away, it still compiled). But are
there any cards out there that bear LSI Logic's vendor ID (1000) and the
MegaRAID version 1 device ID (9010)? I'm thinking not.

Since LSI just started making MegaRAID cards at version 3. That is what
I ment was invalid, the full line, LSI + MEGARAID. All cards with
LSI_LOGIC as the vendor will be MEGARAID3 (1960).

The older version of megaraid.c didn't include an LSI + MEGARAID, but
did have an LSI + MEGARAID3. The new version was the other way around,
and didn't detect my card any longer. In my first patch, I just added a
new ID. But after a little thinking and back tracking, I figured it was
probably a copy and paste error, and the '3' was dropped from the device
ID. A new defination wasn't needed, just a correction to the mis-copied
one.

--
Chris

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/